Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enter missing attrs in datastores as "", rather than None #123

Merged
merged 2 commits into from
Sep 29, 2023

Conversation

dougiesquire
Copy link
Collaborator

Quick fix because Intake-ESM search functionality does not like Nones, so using "" instead

@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (635d10f) 97.16% compared to head (5532fc3) 97.16%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #123   +/-   ##
=======================================
  Coverage   97.16%   97.16%           
=======================================
  Files           9        9           
  Lines         565      565           
=======================================
  Hits          549      549           
  Misses         16       16           
Files Coverage Δ
src/access_nri_intake/source/utils.py 97.84% <66.66%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dougiesquire dougiesquire merged commit 3e72ae0 into main Sep 29, 2023
13 of 14 checks passed
@dougiesquire dougiesquire deleted the missing_attrs branch September 29, 2023 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant